eschutho commented on code in PR #25106:
URL: https://github.com/apache/superset/pull/25106#discussion_r1313323397
##########
superset-frontend/src/SqlLab/components/SaveQuery/index.tsx:
##########
@@ -98,6 +98,8 @@ const SaveQuery = ({
const [showSaveDatasetModal, setShowSaveDatasetModal] = useState(false);
const isSaved = !!query.remoteId;
const canExploreDatabase = !!database?.allows_virtual_table_explore;
+ const canShowSaveButton =
+ database?.allows_virtual_table_explore !== undefined;
Review Comment:
what should the value of canShowSaveButton be if database is null or
database.allows_virtual_table_explore is False?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
