sebastianliebscher opened a new pull request, #25170: URL: https://github.com/apache/superset/pull/25170
### SUMMARY This PR practically drops the apt package `build-essential` (`gcc` etc.) from the Docker image, by removing it in the same step it got installed. Important: Users building on top of `apache/superset` would have to install these tools themselves potentially breaking their Dockerfile depending on their usage. ---- Also removed because not needed: - `/var/[log,tmp]/*`: Both dirs are empty. - `/tmp/*`: Basically empty except for a single file from upstream Python Docker image. Removing this file wouldn't save image size. - `apt-get clean`: [runs automatically](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run) for debian-based docker images. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF This results in a smaller image: - uncompressed: `1.29 GB` down to `1.04 GB` - compressed: `382 MB` down to `311 MB` ### TESTING INSTRUCTIONS - check if the image builds: ```docker build . -t test``` - run `docker-compose.yml` based on that image and check if all services are running - successfully run integration tests on that docker stack - successfully run unit test - check GitHub CI ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
