michael-s-molina commented on PR #25164: URL: https://github.com/apache/superset/pull/25164#issuecomment-1706753332
@eschutho Thank you for the improvement. I'll run this in our staging environment to test the change. Assuming it works, https://github.com/apache/superset/pull/24939, https://github.com/apache/superset/pull/24938, https://github.com/apache/superset/pull/24628, https://github.com/apache/superset/pull/24488 all add `ON DELETE CASCADE` constraints. Can you extract the non-blocking logic from the migrations and move it to [migrations/shared/constraints.py](https://github.com/apache/superset/blob/master/superset/migrations/shared/constraints.py)? Can you also use `batch_alter_table` like [redefine](https://github.com/apache/superset/blob/d0305445b2782264834821c3f1276d74c1b5f99f/superset/migrations/shared/constraints.py#L23) does? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
