betodealmeida commented on code in PR #25190:
URL: https://github.com/apache/superset/pull/25190#discussion_r1316273190
##########
superset/sql_lab.py:
##########
@@ -271,7 +272,7 @@ def execute_sql_statement( # pylint:
disable=too-many-arguments,too-many-statem
session.commit()
with stats_timing("sqllab.query.time_executing_query", stats_logger):
logger.debug("Query %d: Running query: %s", query.id, sql)
- db_engine_spec.execute(cursor, sql, async_=True)
+ db_engine_spec.execute(cursor, sql)
Review Comment:
Let's leave the `async_` for now until we understand why it's here (I think
it's for Hive).
```suggestion
db_engine_spec.execute(cursor, sql, async_=True)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
