eschutho commented on code in PR #24964:
URL: https://github.com/apache/superset/pull/24964#discussion_r1320177896
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -207,6 +209,7 @@ export interface ListViewProps<T extends object = any> {
count: number;
pageSize: number;
fetchData: (conf: FetchDataConfig) => any;
+ refreshData?: () => any;
Review Comment:
```suggestion
refreshData?: () => void;
```
nit, but I saw that this was defined as returning void in a different file
##########
Makefile:
##########
@@ -115,3 +115,31 @@ report-celery-beat:
admin-user:
superset fab create-admin
+
+# Create a postgres instance using docker
+# CLI: $ psql postgresql://postgres:1234@localhost:5432/postgres
+# superset_config.py: SQLALCHEMY_DATABASE_URI =
'postgresql://postgres:1234@localhost:5432/postgres'
+db:
+ # start postgres with detached mode
+ docker run -d -p 127.0.0.1:5432:5432 -e POSTGRES_PASSWORD="1234" --name
pg postgres:alpine;\
+ EXIT_CODE=$$?;\
+ echo $$EXIT_CODE;\
+ echo "command exited with $$EXIT_CODE";\
+ if [ $$EXIT_CODE -ne "0" ]; then docker start pg; echo "DB has been
created"; fi
+
+db-stop:
+ docker stop pg
+
+cache:
+ docker run -d --name redis-stack-server -p 6379:6379
redis/redis-stack-server:latest;\
+ EXIT_CODE=$$?;\
+ echo $$EXIT_CODE;\
+ echo "command exited with $$EXIT_CODE";\
+ if [ $$EXIT_CODE -ne "0" ]; then docker start redis-stack-server; echo
"cache has been created"; fi
Review Comment:
curious, why not run the docker compose commands for these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
