sfirke commented on PR #24928: URL: https://github.com/apache/superset/pull/24928#issuecomment-1719486085
hi @kravi21 thanks for this! Here's what I'm thinking: - Superset uses Flask AppBuilder (FAB) for authentication. - I'd rather have a single set of docs to update. I think that should be in FAB. - Right now [FAB docs ](https://flask-appbuilder.readthedocs.io/en/latest/security.html#authentication-oauth) list lots of off-the-shelf options like Azure, Google, but they aren't clear about how to create a new one that isn't listed. Which I think will sometimes need `jwks_uri` like you are adding here, but won't always? If you can change your comment on that line to be `# may be required to generate token` I think we could merge this. And then the proper fix I believe would be to improve the FAB docs to show how you create a new OAuth provider setup. Can you say what OAuth provider you are using? Maybe we could use that as an example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
