sfirke commented on PR #25312: URL: https://github.com/apache/superset/pull/25312#issuecomment-1721455449
Thanks for submitting a PR! I think this is a small improvement, it doesn't hurt, but it is symptomatic of a bigger problem. There is a whole section that describes this process: https://superset.apache.org/docs/databases/docker-add-drivers/ and I'd rather not duplicate that content. It shouldn't need to be in every single database page, ideally. Most DB pages (for instance [MySQL](https://superset.apache.org/docs/databases/mysql/), [Snowflake](https://superset.apache.org/docs/databases/snowflake/)) don't repeat this info. I like how it's documented on the [BigQuery page](https://superset.apache.org/docs/databases/bigquery), where it links back to the main docker driver docs. Could you instead link back to the main add driver page, copying the BigQuery example? I would merge that. Though to me it says something bigger should also be improved if we have to link back to that page from every single DB subpage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
