craig-rueda commented on code in PR #25346:
URL: https://github.com/apache/superset/pull/25346#discussion_r1330776457
##########
superset/extensions/ssh.py:
##########
@@ -78,18 +78,9 @@ def __init__(self) -> None:
self._ssh_manager = None
def init_app(self, app: Flask) -> None:
- ssh_manager_fqclass = app.config["SSH_TUNNEL_MANAGER_CLASS"]
- ssh_manager_classname = ssh_manager_fqclass[
- ssh_manager_fqclass.rfind(".") + 1 :
- ]
- ssh_manager_module_name = ssh_manager_fqclass[
- 0 : ssh_manager_fqclass.rfind(".")
- ]
- ssh_manager_class = getattr(
- importlib.import_module(ssh_manager_module_name),
ssh_manager_classname
- )
-
- self._ssh_manager = ssh_manager_class(app)
+ self._ssh_manager = load_class_from_name(
Review Comment:
Drying this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
