suicide11 commented on code in PR #25340:
URL: https://github.com/apache/superset/pull/25340#discussion_r1335731532
##########
superset/security/manager.py:
##########
@@ -736,7 +736,14 @@ def create_missing_perms(self) -> None:
logger.info("Fetching a set of all perms to lookup which ones are
missing")
all_pvs = set()
- for pv in self.get_session.query(self.permissionview_model).all():
+ for pv in (
+ self.get_session.query(self.permissionview_model)
+ .options(
+ eagerload(self.permissionview_model.permission),
+ eagerload(self.permissionview_model.view_menu),
+ )
+ .all()
+ ):
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
