kgabryje commented on code in PR #25147:
URL: https://github.com/apache/superset/pull/25147#discussion_r1337611371
##########
superset/common/query_context_processor.py:
##########
@@ -284,6 +284,7 @@ def _get_timestamp_format(
label
for label in [
*get_base_axis_labels(query_object.columns),
+ *[col for col in query_object.columns or [] if isinstance(col,
str)],
Review Comment:
Good point, I don't know if there's such risk but can't hurt to make it
bulletproof 👍
##########
superset/common/query_context_processor.py:
##########
@@ -284,6 +284,7 @@ def _get_timestamp_format(
label
for label in [
*get_base_axis_labels(query_object.columns),
+ *[col for col in query_object.columns or [] if isinstance(col,
str)],
Review Comment:
Good point, I don't know if there's such risk but can't hurt to make it
bulletproof 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
