Re: [PR] feat(pdf-support):Added download Dashboard as a PDF support [superset]

[via GitHub]

kasiazjc commented on PR #25460:
URL: https://github.com/apache/superset/pull/25460#issuecomment-1745034033

   > @Yaswanth-Perumalla We also need to keep consistency and add the PDF 
option to dashboard charts and Explore.
   > 
   > By the way, dashboard charts already have the Download submenu. @kasiazjc 
We may want to standardize the nomenclatures and make sure the menus are 
consistent between Dashboard, Dashboard charts, and Explore.
   > 
   > Dashboard:
   > 
   > <img alt="Screenshot 2023-10-03 at 10 40 59" width="215" 
src="https://user-images.githubusercontent.com/70410625/272281820-6e081ffa-0e8b-49c8-92d7-951edecbf630.png";>
   > Dashboard charts:
   > 
   > <img alt="Screenshot 2023-10-03 at 10 36 48" width="367" 
src="https://user-images.githubusercontent.com/70410625/272280636-c998a387-9be5-423f-8c5a-9752f25b6608.png";>
   > Explore:
   > 
   > <img alt="Screenshot 2023-10-03 at 10 41 26" width="401" 
src="https://user-images.githubusercontent.com/70410625/272281881-29757bc9-90d5-46f1-ab33-0f24d5b9b77c.png";>
   
   Thank you @Yaswanth-Perumalla! And @michael-s-molina for all of the 
suggestions, I agree with pretty much all of them 🙏🏻
   
   So:
   
   1. It would be great if download pdf and image would follow the patterns 
that Michael mentioned - so both would be in "Download >"'s  submenu with icons 
   
   2. Agree we could be more specific what kind of image it is, so "Download as 
JPG" would definitely work 
   
   3. To make it all consistent we could have a specific order in which the 
items are displayed in the menu, and I would suggest for it to be:
   
   - Export to .CSV 
   - Export to Excel 
   - Export to JSON 
   - Download as PDF
   - Download as JPG 
   
   We would just skip the options from the order if it's not available. 
   
   I know that the last two bullet points are not a part of the task, but if 
you can work on it @Yaswanth-Perumalla, that would be great! If not - let me 
know :) Thank you! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org