justinpark opened a new pull request, #25523:
URL: https://github.com/apache/superset/pull/25523

   ### SUMMARY
   Following up the no.1 issue of 
https://github.com/apache/superset/pull/25151#issuecomment-1747279563
   
   This commit fixes the bug of mistitled of new tab after renaming the 
existing tab.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
https://github.com/apache/superset/assets/1392866/a2b3e4d3-98bd-42a8-8ffc-6dd58d217964
   
   After:
   
   
https://github.com/apache/superset/assets/1392866/391aa215-b0d7-4992-b1f8-8501ca412ab0
   
   
   ### TESTING INSTRUCTIONS
   Go to SQL Lab and create a new tab
   rename the current untitled tab and then create a new tab
   Check the untitled tab as 'Untitled Query 1'
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to