giftig commented on issue #25518:
URL: https://github.com/apache/superset/issues/25518#issuecomment-1752758536

   I just tried this on the latest master but I'm not able to reproduce the 
issue; I've tried running against both trino version 403 and 428 (the latest 
docker image) and I see query results come back fine. I also see the debug 
logging surrounding the async code reporting correctly:
   
   ```
   (supers→) superset-upstream (issue-25518) $ docker-compose logs | grep 
'Running query'
   superset_app             | 2023-10-09 
10:17:20,472:DEBUG:superset.db_engine_specs.trino:Query 1: Running query: 
SELECT [...]
   superset_app             | 2023-10-09 
10:17:54,813:DEBUG:superset.db_engine_specs.trino:Query 2: Running query: 
SELECT [...]
   superset_app             | 2023-10-09 
10:18:03,445:DEBUG:superset.db_engine_specs.trino:Query 3: Running query: 
SELECT [...]
   (supers→) superset-upstream (issue-25518) $ vim
   (supers→) superset-upstream (issue-25518) $ docker-compose logs | grep 
'Handling cursor'
   superset_app             | 2023-10-09 
10:17:20,571:DEBUG:superset.db_engine_specs.trino:Query 1: Handling cursor
   superset_app             | 2023-10-09 
10:17:54,912:DEBUG:superset.db_engine_specs.trino:Query 2: Handling cursor
   superset_app             | 2023-10-09 
10:18:03,545:DEBUG:superset.db_engine_specs.trino:Query 3: Handling cursor
   ```
   This is using the version of the trino client library listed in superset's 
dependencies, which I installed by listing `-e file:.[postgres,hive,trino]` in 
local dependencies. @villebro did you use any other additional steps to 
reproduce? This seems to be the minimal setup.
   
   I've also tried with async execution both on and off.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to