kasiazjc commented on PR #24449: URL: https://github.com/apache/superset/pull/24449#issuecomment-1757536331
> Hi @kasiazjc I added dropdowns in minute and seconds as you have suggested. Instead of select i used input type with datalist. In datalist i have provided options from 0-59, if user puts some other value and submits then it will display error message. > > datalist is looking little different depending on browsers, some previews are as below. > > **edge browser preview:**  > > **firefox browser preview:**  > > **chrome browser preview:**  > > I was having problem taking screenshot with dropdown, so i took screenshot using phone. > > Please check and review @kasiazjc @rusackas Sorry for the super late review! Missed this PR. These are not ant design components right? I think single select with predefined list in the dropdown we have in code should be the one used in this for consistency (design and patterns). You can find it in filters for example, and users can also type in some numbers (it just would not accept the new number) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
