jsoref opened a new pull request, #25638:
URL: https://github.com/apache/superset/pull/25638

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   when pre-commit fails, it's typically because of changes made by one of the 
tools. As it *knows* what the changes are, this change provides access to 
people so that they can use `patch -p1` to apply the changes instead of just 
being frustrated by an unhelpful CI.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   Before:
   https://github.com/apache/superset/actions/runs/6507284267/job/17674397883
   <img width="945" alt="image" 
src="https://github.com/apache/superset/assets/2119212/a6dce581-9ba6-41f7-b82f-65a9da2279a7";>
   
   After:
   
https://github.com/check-spelling-sandbox/superset/actions/runs/6509697746/job/17681762469
   <img width="1288" alt="image" 
src="https://github.com/apache/superset/assets/2119212/854a7d05-2415-42a3-bf20-04fc3cf3208b";>
   
   
   ### TESTING INSTRUCTIONS
   1. Make a change to a helm chart that's incomplete such that pre-commit will 
fail.
   2. Make a PR to a branch with this modified workflow 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to