giftig commented on PR #25541: URL: https://github.com/apache/superset/pull/25541#issuecomment-1763979468
Bear in mind that merging this PR fixes an issue which seems to only be reproducible on mac OS but re-introduces a bug which prevents trino queries being stopped across all environments. I'm currently blocked from amending this fix because I can't reproduce the issue after several attempts and it isn't clear what the scope of the bug is. I think it's important to understand that impact, because it's a fairly major bug that's been introduced by reverting this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
