michael-s-molina commented on code in PR #25666:
URL: https://github.com/apache/superset/pull/25666#discussion_r1365679029
##########
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/controlPanel.tsx:
##########
@@ -101,7 +102,33 @@ const config: ControlPanelConfig = {
t('Category, Value and Percentage'),
],
],
- description: t('What should be shown on the label?'),
+ description: t('What should be shown as the label'),
+ },
+ },
+ ],
+ [
+ {
+ name: 'tooltip_label_type',
+ config: {
+ type: 'SelectControl',
+ label: t('Tooltip Contents'),
+ default: defaultTooltipLabel,
+ renderTrigger: true,
+ choices: [
+ [EchartsFunnelLabelTypeType.Key, t('Category Name')],
+ [EchartsFunnelLabelTypeType.Value, t('Value')],
+ [EchartsFunnelLabelTypeType.Percent, t('Percentage')],
+ [EchartsFunnelLabelTypeType.KeyValue, t('Category and Value')],
+ [
+ EchartsFunnelLabelTypeType.KeyPercent,
+ t('Category and Percentage'),
+ ],
+ [
+ EchartsFunnelLabelTypeType.KeyValuePercent,
+ t('Category, Value and Percentage'),
+ ],
+ ],
+ description: t('What should be shown as the tooltip Label'),
Review Comment:
```suggestion
description: t('What should be shown as the tooltip label'),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
