justinpark opened a new pull request, #25741: URL: https://github.com/apache/superset/pull/25741
### SUMMARY Since #22102 migrated fetch_datasource_metadata to api v1, "View in SQL LAB" from explore became very slow when the selected dataset contains a lot of columns/metadata. This commit changes the popDatasourceQuery to improve performance by only including the necessary columns. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: <img width="657" alt="Screenshot 2023-10-23 at 1 11 54 PM" src="https://github.com/apache/superset/assets/1392866/52d994a3-0deb-4d45-8e02-edbe37fbae03";> After: <img width="925" alt="Screenshot 2023-10-23 at 1 10 29 PM" src="https://github.com/apache/superset/assets/1392866/ae4bc4ab-a54e-49fa-b1b0-f190b8139b92";> ### TESTING INSTRUCTIONS Go to a explore view of any charts Click "View in SQL Lab" and check the network tab for `api/v1/datasets/[id]` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
