sebastianliebscher commented on code in PR #25847:
URL: https://github.com/apache/superset/pull/25847#discussion_r1380574022
##########
superset/async_events/api.py:
##########
@@ -33,6 +34,7 @@ class AsyncEventsRestApi(BaseSupersetApi):
allow_browser_login = True
@expose("/", methods=("GET",))
+ @statsd_metrics
@event_logger.log_this
@protect()
Review Comment:
Most API endpoints already use `@statsd_metrics`. When this decorator is
added to replace implicit `log_to_statsd=True`, the statsd metric
- `superset_<Endpoint>`
will be replaced by
- `superset_<Class>_<Endpoint>_success|warning|error`
- `superset_<Class>_<Endpoint>_time`
- `superset_<Class>_<Endpoint>_time_count`
- `superset_<Class>_<Endpoint>_time_sum`
So it is kind of a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
