michael-s-molina commented on PR #25844: URL: https://github.com/apache/superset/pull/25844#issuecomment-1804170706
> @michael-s-molina couldn’t you extend that same logic for any change, i.e., in https://github.com/apache/superset/pull/25819 what if someone was referring to the old class? The difference in this case is that tags are not officially released yet. > I guess it really depends on one’s interpretation of what’s public and in this case whether the intent is for DAOs to extended/leveraged in custom configurations. I agree. Some parts are easy to identify as potential for breaking changes such as APIs or database engine specs. Other parts such as DAOs or form data are not so clear. Maybe we should bring this discussion to the Town Hall and formalize the constraints. @villebro @rusackas @betodealmeida @eschutho -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org