justinpark commented on code in PR #25869:
URL: https://github.com/apache/superset/pull/25869#discussion_r1388486820
##########
superset-frontend/babel.config.js:
##########
@@ -22,6 +22,12 @@ module.exports = {
sourceMaps: true,
sourceType: 'module',
retainLines: true,
+ // After adding transformIgnorePatterns to jest.config.js
+ // the tests failed. Following line fixed the problem. See also
+ // https://github.com/babel/babel/issues/8731#issuecomment-423845498
+ // core-js seems to be packaged as commonjs modules, so it should
+ // be (more or less) save to ignore them with babel.
+ ignore: [/^core-js$/],
Review Comment:
These are likely side effects of changes to package.json. Please clean up
package.json as suggested, and these changes should no longer be necessary.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
