john-bodley commented on code in PR #25948:
URL: https://github.com/apache/superset/pull/25948#discussion_r1389793257
##########
superset/views/base.py:
##########
@@ -139,15 +141,11 @@ def get_error_msg() -> str:
def json_error_response(
- msg: Optional[str] = None,
+ msg: str | None = None,
status: int = 500,
- payload: Optional[dict[str, Any]] = None,
- link: Optional[str] = None,
Review Comment:
@sebastianliebscher it seems like the `payload` argument isn't use in the
codebase either.
##########
superset/views/base.py:
##########
@@ -682,18 +674,14 @@ def apply(self, query: Query, value: Any) -> Query:
class CsvResponse(Response):
- """
- Override Response to take into account csv encoding from config.py
- """
+ """Override Response to take into account csv encoding from config.py"""
Review Comment:
Were these comments manually or automatically changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
