michael-s-molina commented on code in PR #25952:
URL: https://github.com/apache/superset/pull/25952#discussion_r1395695864
##########
superset/migrations/shared/migrate_viz/processors.py:
##########
@@ -163,23 +141,19 @@ def _pre_action(self) -> None:
"difference" if comparison_type == "absolute" else comparison_type
)
+ if x_ticks_layout := self.data.get("x_ticks_layout"):
+ self.data["x_ticks_layout"] = 45 if x_ticks_layout == "45°" else 0
+
class MigrateLineChart(TimeseriesChart):
source_viz_type = "line"
target_viz_type = "echarts_timeseries_line"
- rename_keys = {
Review Comment:
Moved to Timeseries.
##########
superset/migrations/shared/migrate_viz/processors.py:
##########
@@ -163,23 +141,19 @@ def _pre_action(self) -> None:
"difference" if comparison_type == "absolute" else comparison_type
)
+ if x_ticks_layout := self.data.get("x_ticks_layout"):
+ self.data["x_ticks_layout"] = 45 if x_ticks_layout == "45°" else 0
+
class MigrateLineChart(TimeseriesChart):
source_viz_type = "line"
target_viz_type = "echarts_timeseries_line"
- rename_keys = {
Review Comment:
Moved to TimeseriesChart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
