john-bodley commented on code in PR #25952:
URL: https://github.com/apache/superset/pull/25952#discussion_r1396084074
##########
superset/migrations/shared/migrate_viz/processors.py:
##########
@@ -137,10 +103,22 @@ class MigrateSunburst(MigrateViz):
class TimeseriesChart(MigrateViz):
has_x_axis_control = True
+ rename_keys = {
+ "bottom_margin": "x_axis_title_margin",
+ "left_margin": "y_axis_title_margin",
+ "show_controls": "show_extra_controls",
+ "x_axis_label": "x_axis_title",
+ "x_axis_format": "x_axis_time_format",
+ "x_ticks_layout": "xAxisLabelRotation",
+ "y_axis_label": "y_axis_title",
+ "y_axis_showminmax": "truncateYAxis",
+ "y_log_scale": "logAxis",
+ }
+ remove_keys = {"contribution", "show_brush", "show_markers"}
def _pre_action(self) -> None:
self.data["contributionMode"] = "row" if self.data.get("contribution")
else None
- self.data["zoomable"] = self.data.get("show_brush") != "no"
+ self.data["zoomable"] = self.data.get("show_brush") == "yes"
Review Comment:
@michael-s-molina could we change to PR description to be something of the
form:
> Adds Area chart migration and tweaks the Timeseries chart migration
which will aid developers if they're trying to bisect when/where a possible
change occured.
##########
superset/migrations/shared/migrate_viz/processors.py:
##########
@@ -137,10 +103,22 @@ class MigrateSunburst(MigrateViz):
class TimeseriesChart(MigrateViz):
has_x_axis_control = True
+ rename_keys = {
+ "bottom_margin": "x_axis_title_margin",
+ "left_margin": "y_axis_title_margin",
+ "show_controls": "show_extra_controls",
+ "x_axis_label": "x_axis_title",
+ "x_axis_format": "x_axis_time_format",
+ "x_ticks_layout": "xAxisLabelRotation",
+ "y_axis_label": "y_axis_title",
+ "y_axis_showminmax": "truncateYAxis",
+ "y_log_scale": "logAxis",
+ }
+ remove_keys = {"contribution", "show_brush", "show_markers"}
def _pre_action(self) -> None:
self.data["contributionMode"] = "row" if self.data.get("contribution")
else None
- self.data["zoomable"] = self.data.get("show_brush") != "no"
+ self.data["zoomable"] = self.data.get("show_brush") == "yes"
Review Comment:
@michael-s-molina could we change to PR description to be something of the
form,
> Adds Area chart migration and tweaks the Timeseries chart migration
which will aid developers if they're trying to bisect when/where a possible
change occurred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
