rusackas opened a new pull request, #26011: URL: https://github.com/apache/superset/pull/26011
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR does a handful of things: • Adds the Scarf pixel to Superset (as approved by SIP) via a new `TelemetryPixel` component • Adds the `ENABLE_TELEMETRY` feature flag • Adds basic tests for the above • Bumps react types to support the `no-referrer-when-downgrade` • Bumps the npm version... not that I intended to, but it keeps coming along for the ride TODO: • Get the pixel to load via Scarf gateway so that url params (version/sha/build) are reliably captured • Feature flag documentation • Turn off _more_ Scarf stuff with this flag? ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> RTL tests for the new component with FF on and off should pass. Run it, and have any PMC member check the Scarf data for proper capture. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/25639 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
