rusackas commented on PR #26022: URL: https://github.com/apache/superset/pull/26022#issuecomment-1819772332
My two cents here: If we are considering a redesign, then we should make the smallest possible UI change here to support the use case for the moment. I fear that pulling out all the day/month/etc ranges into the Select menu is... not ideal. I would just copy the pattern for "Last" and make a new option for "Current" with similar radio button options: <img width="649" alt="Screenshot_2023-11-20_at_1_34_33 PM" src="https://github.com/apache/superset/assets/812905/7602e1c0-b4f9-42ad-9d11-3117a3f62336";> The customizable options via config.py are still interesting/useful, but this seems like a common use case that we ought to support as a mainstream feature. I'm also not sure what the maintenance/documentation requirements would be if people start using these custom config options frequently in installations around the world. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
