john-bodley commented on code in PR #26106:
URL: https://github.com/apache/superset/pull/26106#discussion_r1409663365
##########
tests/integration_tests/core_tests.py:
##########
@@ -714,10 +714,16 @@ def test_explore_json_async(self):
keys = list(data.keys())
# If chart is cached, it will return 200, otherwise 202
- self.assertTrue(rv.status_code in {200, 202})
- self.assertCountEqual(
- keys, ["channel_id", "job_id", "user_id", "status", "errors",
"result_url"]
- )
+ assert rv.status_code in {200, 202}
Review Comment:
@villebro I was wondering whether it would be easier/simpler to disable the
caching for this test so the response status code is always 200. The only
caveat is whether we should be testing both scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
