betodealmeida opened a new pull request, #26140: URL: https://github.com/apache/superset/pull/26140
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> A confusing bug in the annotation layers... it seems that in the form data the `granularity` attribute stores the time grain (eg, `P1D` for daily time grain): https://github.com/apache/superset/blob/f1a6b2f852eb879e69c7a93803cf0dd2ed58ce76/superset-frontend/src/explore/controls.jsx#L248-L270 But in the request payload, `granularity` should point to the column name, not the grain: https://github.com/apache/superset/blob/f1a6b2f852eb879e69c7a93803cf0dd2ed58ce76/superset/charts/schemas.py#L1146-L1149 When generating an annotation query we need to move things around to match the form data to the request schema. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
