michael-s-molina commented on code in PR #26207:
URL: https://github.com/apache/superset/pull/26207#discussion_r1419298981


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Step/controlPanel.tsx:
##########
@@ -184,6 +184,7 @@ const config: ControlPanelConfig = {
               choices: [
                 [0, '0°'],
                 [45, '45°'],
+                [90, '90°'],

Review Comment:
   This is just one example of the many code duplication in the ECharts 
plugins. I'm planning to improve all this once the migrations are complete.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to