villebro commented on code in PR #26215:
URL: https://github.com/apache/superset/pull/26215#discussion_r1419943354
##########
superset-frontend/plugins/plugin-chart-echarts/src/Bubble/constants.ts:
##########
@@ -26,6 +26,7 @@ export const DEFAULT_FORM_DATA:
Partial<EchartsBubbleFormData> = {
logYAxis: false,
xAxisTitleMargin: 30,
yAxisTitleMargin: 30,
+ truncateXAxis: false,
Review Comment:
Note that for bubble chart, I'm assuming truncation is disabled, as it's
more likely people want to see it starting from origo in this case (having a
truncated x axis but a non-truncated y axis doesn't make sense for a scatter
plot IMO).
##########
superset-frontend/plugins/plugin-chart-echarts/src/Bubble/constants.ts:
##########
@@ -26,6 +26,7 @@ export const DEFAULT_FORM_DATA:
Partial<EchartsBubbleFormData> = {
logYAxis: false,
xAxisTitleMargin: 30,
yAxisTitleMargin: 30,
+ truncateXAxis: false,
Review Comment:
Note that for bubble chart, I'm assuming truncation is disabled by default,
as it's more likely people want to see it starting from origo in this case
(having a truncated x axis but a non-truncated y axis doesn't make sense for a
scatter plot IMO).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
