hughhhh commented on code in PR #26324:
URL: https://github.com/apache/superset/pull/26324#discussion_r1435248115
##########
tests/integration_tests/tags/dao_tests.py:
##########
@@ -124,13 +124,19 @@ def create_tagged_objects(self):
@pytest.mark.usefixtures("with_tagging_system_feature")
# test create tag
def test_create_tagged_objects(self):
- # test that a tag cannot be added if it has ':' in it
- with pytest.raises(DAOCreateFailedError):
- TagDAO.create_custom_tagged_objects(
- object_type=ObjectType.dashboard.name,
- object_id=1,
- tag_names=["invalid:example tag 1"],
- )
+ # test that a tag can be added if it has ':' in it
+ TagDAO.create_custom_tagged_objects(
+ object_type=ObjectType.dashboard.name,
+ object_id=1,
+ tag_names=["valid:example tag 1"],
+ )
+
+ # test that a tag can be added if it has ',' in it
+ TagDAO.create_custom_tagged_objects(
Review Comment:
can we add few more test with different symbols? like `.`, `-`, `/`, etc.
##########
tests/integration_tests/tags/dao_tests.py:
##########
@@ -124,13 +124,19 @@ def create_tagged_objects(self):
@pytest.mark.usefixtures("with_tagging_system_feature")
# test create tag
def test_create_tagged_objects(self):
- # test that a tag cannot be added if it has ':' in it
- with pytest.raises(DAOCreateFailedError):
- TagDAO.create_custom_tagged_objects(
- object_type=ObjectType.dashboard.name,
- object_id=1,
- tag_names=["invalid:example tag 1"],
- )
+ # test that a tag can be added if it has ':' in it
+ TagDAO.create_custom_tagged_objects(
+ object_type=ObjectType.dashboard.name,
+ object_id=1,
+ tag_names=["valid:example tag 1"],
+ )
+
+ # test that a tag can be added if it has ',' in it
+ TagDAO.create_custom_tagged_objects(
Review Comment:
nit: can we add few more test with different symbols? like `.`, `-`, `/`,
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
