rekilina opened a new pull request, #26354:
URL: https://github.com/apache/superset/pull/26354

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   There are some custom visualizations which allow to perform cross-filtration 
over multiple columns. In this case, current implementation of cross-filters 
tag does not display data correctly, since it shows only the first column name. 
For example, it can be seen in Pivot Table with multi-select. This fix allows 
to display all column names and corresponding values in the cross-filter tag.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   
![изображение](https://github.com/apache/superset/assets/76280175/5d40f8a3-1f44-41d7-a2cb-28e7465b08e3)
   After:
   
![изображение](https://github.com/apache/superset/assets/76280175/fe977f84-7422-46f6-93b8-62b0f7207265)
   
   ### TESTING INSTRUCTIONS
   1. In Pivot Table plugin (PivotTableChart.tsx) in the toggleFilter function, 
un-comment code concerning multi select and comment code of single select. 
   
https://github.com/apache/superset/blob/b6d433de32cad21c0866ee98fd5ae85b4459c23b/superset-frontend/plugins/plugin-chart-pivot-table/src/PivotTableChart.tsx#L407-L420
   2. Open any dashboard with Pivot Table and select values from different 
columns.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to