sivasathyaseeelan opened a new pull request, #26387:
URL: https://github.com/apache/superset/pull/26387

   
   Added chart examples for left out chart types in issue #16707 and modified 
VizTypeGallery.tsx for rendering thumbnail image in case of no example provided
   
   
   ### SUMMARY
   
   Adding chart examples for Deck.gl:
   * Arc
   * Grid
   * Hexagon
   * Path
   * Polygon
   * Scatterplot
   * Screen Grid
   * Contour
   * Heatmap
   * Geojson
   
   And made a change in VizTypeGallery.tsx for rendering thumbnail image in 
case of no example provided
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   ####BEFORE
   
![image](https://github.com/apache/superset/assets/95441117/d0c2b82a-e97c-4eef-92ae-90835566b28c)
   
   ####AFTER
   [Screencast from 01-01-24 02:37:27 PM 
IST.webm](https://github.com/apache/superset/assets/95441117/a79421ec-d488-4c34-a069-273e82117c09)
   
   ### TESTING INSTRUCTIONS
   Kindly go to 
[http://localhost:9000/chart/add](http://localhost:9000/chart/add) and please 
select any chart so that you can be able to see example images of selected chart
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   Fixes #16707 
   - [x] Has associated issue: #16707 
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to