betodealmeida commented on issue #26395:
URL: https://github.com/apache/superset/issues/26395#issuecomment-1874633438

   Nice!
   
   I have a few questions and comments:
   
   1. Should we have the DB/schema selectors above both the sidebar and the SQL 
editor, to reinforce the fact that the selection applies to both panels? 
Something like (apologies for the poor ASCII art):
   
   ```
    _______________________________________
   |                                       |
   | [database selector] [schema selector] |
   |_______________________________________|
   |                   |                   |
   | sidebar           | SQL editor        |
   |___________________|___________________|
   ```
   
   My impression with your proposed design is that it's not clear that the 
selection in the SQL editor panel applies to the sidebar, since the panels are 
siblings hierarchically.
   
   2. What happens when databases have thousands of tables? Are we going to 
paginate the sidebar?
   3. Currently we have some affordances to show extra table metadata (in 
Presto, Hive, Trino, BigQuery, and GSheets). How are these going to be 
displayed in the new design?
   4. We've been discussing [adding support for 
catalogs](https://github.com/apache/superset/issues/22862) (projects, in 
BigQuery terms) to Superset. It would be nice to keep that in mind during this 
redesign, to make that work easier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to