john-bodley commented on code in PR #24605:
URL: https://github.com/apache/superset/pull/24605#discussion_r1439977722
##########
.github/workflows/superset-python-integrationtest.yml:
##########
@@ -150,7 +150,9 @@ jobs:
SUPERSET_CONFIG: tests.integration_tests.superset_test_config
REDIS_PORT: 16379
SUPERSET__SQLALCHEMY_DATABASE_URI: |
- sqlite:///${{ github.workspace }}/.temp/unittest.db
+ sqlite:///${{ github.workspace }}/.temp/superset.db
+ SUPERSET__SQLALCHEMY_EXAMPLES_URI: |
Review Comment:
This threw me for a curveball as for some tests the metadata database _only_
contained example tables. Per
[here](https://github.com/apache/superset/blob/9033e72679fad7efdabc0f5b28607d974a7b5e1f/tests/integration_tests/superset_test_config.py#L46-L48),
if undefined the metadata and example databases are the same and given that
SQLite doesn't support schemas there likely exists race conditions where tables
were being wrongfully altered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
