michael-s-molina commented on PR #26377: URL: https://github.com/apache/superset/pull/26377#issuecomment-1878573344
> @michael-s-molina although the redirect endpoint is deprecated and the functionality for creating `/r` links no longer exists, I wonder if we should _try_ to preserve these URLs (for some period) by: > > 1. Migrate the records from the `url` to the `key_value` table where the `resource` column is `redirect` and the `value` column is a JSON key/value pair mapping `url.id` to `url.url`. These records could have an expiration of 1–2 years given the somewhat transient nature of URLs. > 2. Keep the `/r` link endpoint which—albeit inefficiently—scans the `key_value` table (by leveraging JSON UDFs) where the `resource` column is `redirect` and the `value` column contains the `/r` ID as they key. > > Alternatively, if code bloat is less of a concern, we could maybe punt this PR (as is) until v6.0 (or later) given the increased likelihood that the legacy redirects would be unused. If we're going to keep the `/r` endpoint for some period, I think is easier to keep the values in the `url` table, avoid the migrations, and punt this proposal to 5.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
