giftig commented on PR #25696: URL: https://github.com/apache/superset/pull/25696#issuecomment-1880695785
Not sure if this is directly related, but I've seen frontend build errors while running the project in docker-compose with the latest master: ``` ERROR in ./node_modules/jspdf/dist/jspdf.es.min.js 128:659-680 Module not found: Error: Can't resolve 'html2canvas' in '/app/superset-frontend/node_modules/jspdf/dist' ERROR in ./node_modules/jspdf/dist/jspdf.es.min.js 291:65-80 Module not found: Error: Can't resolve 'canvg' in '/app/superset-frontend/node_modules/jspdf/dist' ``` and it looks like `jspdf` is used by `dom-to-pdf`, which was first used in this change. @fisjac maybe you'll have a better idea what might be happening here than me, I'm not very familiar with these packages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
