michael-s-molina commented on PR #26350: URL: https://github.com/apache/superset/pull/26350#issuecomment-1880829168
> @michael-s-molina I was wondering if the title of the PR "refactor: Removes the legacy Sunburst chart" should be updated? > > A non-informed reader may recoil thinking that you're simply removing the legacy chart, whereas in actuality you're actually migrating all their legacy charts to the ECharts equivalent and annexing all the legacy code. Good call out. I changed the PR title to "refactor: Migrates legacy Sunburst charts to ECharts and removes legacy code" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
