dpgaspar commented on code in PR #26344:
URL: https://github.com/apache/superset/pull/26344#discussion_r1444733630
##########
superset/views/core.py:
##########
@@ -239,8 +239,6 @@ def explore_json_data(self, cache_key: str) ->
FlaskResponse:
return json_error_response(utils.error_msg_from_exception(ex), 400)
EXPLORE_JSON_METHODS = ["POST"]
- if not is_feature_enabled("ENABLE_EXPLORE_JSON_CSRF_PROTECTION"):
Review Comment:
To my understanding this feature flag would allow `explore_json` to accept
HTTP GETs but still imposing CSRF protection. So when `False` this endpoint
would only accept HTTP POSTs and so would be automatically protected to CSRF.
Shouldn't we keep the same behaviour and just allow for POST and be always
protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
