villebro opened a new pull request, #26429: URL: https://github.com/apache/superset/pull/26429
### SUMMARY If your data contains nulls, using the cumsum operator will cause gaps in the chart. This is because null values appear as nulls in the series instead of the cumulative value. To avoid this, we replace nulls with zeros before applying the operator, ensuring that all values are present in the series. ### AFTER Now gaps in the data won't cause the bar to be truncated: <img width="1093" alt="image" src="https://github.com/apache/superset/assets/33317356/38053c39-9fd7-4ce7-8cdf-0eab155116e9";> ### BEFORE Previously, missing values would cause the cumulative series to be missing in the chart, causing gaps in the graph: <img width="1092" alt="image" src="https://github.com/apache/superset/assets/33317356/1685ba06-2463-470b-972b-4ea748989387";> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
