Vitor-Avila opened a new pull request, #26461:
URL: https://github.com/apache/superset/pull/26461

   ### SUMMARY
   The `BigQueryEngineSpec` has `allows_hidden_cc_in_orderby` set to `True`, so 
the `ORDER BY` statement uses the actual metric/dimension alias, rather than 
its SQL expression (implementation PR: 
https://github.com/apache/superset/pull/17196).
   
   In case the metric alias has a special characters (like accents or Chinese 
characters for example), the query will throw an error.
   
   Fixes https://github.com/apache/superset/issues/26459
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:**
   
   
https://github.com/apache/superset/assets/96086495/3db44c50-1fbb-4809-a123-cd4ea23f65ca
   
   **After:**
   
   
https://github.com/apache/superset/assets/96086495/36a0745a-0f67-4130-934a-2abc77b0ff70
   
   
   
   
   ### TESTING INSTRUCTIONS
   1. Create a dataset from a BQ connection.
   2. Use it to create a **Table** chart.
   3. Add any column as its dimension, and create a metric named `métric` using 
`COUNT(*)` as its SQL expression.
   
   ### ADDITIONAL INFORMATION
   - [X] Has associated issue: https://github.com/apache/superset/issues/26459
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to