geido opened a new pull request, #26634:
URL: https://github.com/apache/superset/pull/26634

   ### SUMMARY
   The style of the RLS modal presented a few issues:
   
   - Info icons should be centered with the text horizontally
   - There should be the same spacing between the labels and inputs vertically
   - The colors of the labels should all be the same
   - The border color of the description field should be same as others
   
   ### BEFORE
   
   <img width="930" alt="Screenshot 2024-01-16 at 17 20 21" 
src="https://github.com/apache/superset/assets/60598000/29597b15-2185-43a2-87b8-b9235e93cf0a";>
   
   
   ### AFTER
   
   <img width="1180" alt="Screenshot 2024-01-16 at 17 16 15" 
src="https://github.com/apache/superset/assets/60598000/cb7d95c8-36b3-4640-8082-18d6d3914248";>
   
   
   ### TESTING INSTRUCTIONS
   1. Add a new rule in the Row Level Security settings
   2. Make sure the style of the modal is consistent with other modals in 
Superset
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to