mistercrunch commented on code in PR #26654:
URL: https://github.com/apache/superset/pull/26654#discussion_r1458133417
##########
tests/integration_tests/tags/commands_tests.py:
##########
@@ -63,7 +63,7 @@ def test_create_custom_tag_command(self):
example_dashboard = (
db.session.query(Dashboard).filter_by(slug="world_health").one()
)
- example_tags = ["create custom tag example 1", "create custom tag
example 2"]
+ example_tags = {"create custom tag example 1", "create custom tag
example 2"}
Review Comment:
wondering if that was flaky before, but it turned flaky with the new logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]