michael-s-molina opened a new pull request, #26679:
URL: https://github.com/apache/superset/pull/26679

   ### SUMMARY
   https://github.com/apache/superset/pull/26552 bumped `swagger-ui-react` from 
4.1.3 to 5.11.0. As a side effect, the `react-redux` dependency in yarn.lock 
was also upgraded from 7.1.20 to 9.0.4 which requires React 18. Given that the 
docs project uses React 17, it produced the following error:
   
   ```
   Attempted import error: 'useSyncExternalStore' is not exported from 'react' 
(imported as 'React2').
   ```
   
   Another side effect of the upgrade was:
   
   ```
   Module not found: Error: Can't resolve 'url' in 
'/home/runner/work/superset/superset/docs/
   
node_modules/@saucelabs/theme-github-codeblock/build/theme/ReferenceCodeBlock'
   BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core 
modules by default.
   Error:  Client bundle compiled with errors therefore further build is 
impossible.
   This is no longer the case. Verify if you need this module and configure a 
polyfill for it.
   If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "url": require.resolve("url/") }'
        - install 'url'
   If you don't want to include a polyfill, you can use an empty module like 
this:
        resolve.fallback: { "url": false }
   ```
   
   This PR reverts the change.
   
   ### TESTING INSTRUCTIONS
   CI.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to