puridach-w opened a new pull request, #26755: URL: https://github.com/apache/superset/pull/26755
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY The feature change involves retaining search filter results across SQL Lab tabs by integrating search text into the Redux state. Under the previous system, users would encounter the resetting of their search results each time they switched to a different SQL Lab tab and back. This process required users to repeatedly enter their search filters, resulting in a disrupted workflow. This enhancement directly tackles this inconvenience. Upon rendering SQL Lab, it now utilizes the search text stored in Redux state as the filter value. This ensures that no matter how many tabs a user switches between, the search filter results remain persistent, no longer disappearing upon tab switching. ### BEFORE SCREENSHOTS OR ANIMATED GIF https://github.com/apache/superset/assets/76474644/79a9d872-87c3-49d9-9e9e-01b958c4f86c ### AFTER SCREENSHOTS OR ANIMATED GIF https://github.com/apache/superset/assets/76474644/e091d7a6-132f-4951-a3dd-98557a7e3d2f ### TESTING INSTRUCTIONS - Navigate to the SQLLab page - Execute Query - Apply a filter on the resulting output table using the search box - Navigate to other SQL editor tab - Return to the initial SQL editor tab - Notice that the previously input search text and filter results are still visible ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
