betodealmeida commented on code in PR #26767:
URL: https://github.com/apache/superset/pull/26767#discussion_r1464064524
##########
superset/connectors/sqla/models.py:
##########
@@ -1414,26 +1415,6 @@ def mutate_query_from_config(self, sql: str) -> str:
def get_template_processor(self, **kwargs: Any) -> BaseTemplateProcessor:
return get_template_processor(table=self, database=self.database,
**kwargs)
- def get_query_str_extended(
Review Comment:
This method is **identical** to the base class.
##########
superset/connectors/sqla/models.py:
##########
@@ -1475,33 +1456,6 @@ def get_from_clause(
return from_clause, cte
- def get_rendered_sql(
Review Comment:
This method is **identical** to the base class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
