john-bodley commented on code in PR #26735:
URL: https://github.com/apache/superset/pull/26735#discussion_r1465335341


##########
superset/db_engine_specs/base.py:
##########
@@ -397,6 +397,9 @@ class BaseEngineSpec:  # pylint: 
disable=too-many-public-methods
     # Can the catalog be changed on a per-query basis?
     supports_dynamic_catalog = False
 
+     # Use column alias instead of aggregate function in GROUP BY

Review Comment:
   ```suggestion
       # Use column alias instead of aggregate function in GROUP BY
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to