justinpark commented on code in PR #26754:
URL: https://github.com/apache/superset/pull/26754#discussion_r1465381657
##########
superset-frontend/src/SqlLab/components/SqlEditor/index.tsx:
##########
@@ -759,6 +760,10 @@ const SqlEditor: React.FC<Props> = ({
);
};
+ const handleCursorPositionChange = (newPosition: any) => {
Review Comment:
Since you already added[ type for the cursor
position,](https://github.com/apache/superset/pull/26754/files#diff-98bfde8ed111b1aa1a94f5da25ed87585b19908a628063fd133958e9576c239aR38)
please use `CursorPosition` instead of any type
```suggestion
const handleCursorPositionChange = (newPosition: CursorPosition) => {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
