michael-s-molina opened a new pull request, #26807:
URL: https://github.com/apache/superset/pull/26807

   ### SUMMARY
   Follow-up of https://github.com/apache/superset/pull/26151 to update the 
control with the `SQL_MAX_ROW` configuration.
   
   Fixes https://github.com/apache/superset/issues/26779
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   After the change, we are able to set a 1 million limit.
   <img width="326" alt="Screenshot 2024-01-25 at 15 40 44" 
src="https://github.com/apache/superset/assets/70410625/16cd9c04-7358-47b2-9efd-5efb4bd0dd19";>
   <img width="346" alt="Screenshot 2024-01-25 at 15 41 11" 
src="https://github.com/apache/superset/assets/70410625/5084e75c-55bb-4506-bcd2-4f4259471ba7";>
   
   ### TESTING INSTRUCTIONS
   1 - Change SQL_MAX_ROW to a value greater than 100,000
   2 - Check that you are able to set a value according to the new row limit
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to