shakeelansari63 commented on code in PR #26663:
URL: https://github.com/apache/superset/pull/26663#discussion_r1467668987
##########
helm/superset/templates/secret-env.yaml:
##########
@@ -34,6 +34,10 @@ stringData:
REDIS_PASSWORD: {{ .Values.supersetNode.connections.redis_password | quote
}}
{{- end }}
REDIS_PORT: {{ .Values.supersetNode.connections.redis_port | quote }}
+ REDIS_PROTO: {{ if .Values.supersetNode.connections.use_redis_ssl
}}"rediss"{{ else }}"redis"{{ end }}
+ REDIS_DB: {{ .Values.supersetNode.connections.redis_cache_db | quote }}
+ REDIS_CELERY_DB: {{ .Values.supersetNode.connections.redis_celery_db |
quote }}
+ REDIS_SSL_PARAM: {{ if .Values.supersetNode.connections.use_redis_ssl
}}"?ssl_cert_reqs={{
.Values.supersetNode.connections.use_redis_ssl.ssl_cert_reqs | default
"CERT_NONE" }}"{{ else }}""{{ end }}
Review Comment:
@dpgaspar , The logic is here as we need ssl_cert_reqs only while using the
ssl protocol. Are you suggesting we set the `REDIS_SSL_CERT_REQS` envvar only
when ssl is needed.
So `secret-env.yaml` can be something like this -
```yaml
{{- if .Values.supersetNode.connections.use_redis_ssl }}
REDIS_SSL_CERT_REQS: {{
.Values.supersetNode.connections.use_redis_ssl.ssl_cert_reqs | default
"CERT_NONE" }}
{{- end }}
```
So we will now build the URL as follow -
```python
broker_url = f"{REDIS_BASE_URL}/{env('REDIS_CELERY_DB',
0)}{'?ssl_cert_reqs='+env('REDIS_SSL_CERT_REQS') if env('REDIS_SSL_CERT_REQS')
else ''}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
